Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14351 )
Change subject: [clock] remove 'experimental' tag from some clock-related flags ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/14351/1/src/kudu/clock/builtin_ntp.cc File src/kudu/clock/builtin_ntp.cc: http://gerrit.cloudera.org:8080/#/c/14351/1/src/kudu/clock/builtin_ntp.cc@70 PS1, Line 70: TAG_FLAG(builtin_ntp_servers, advanced); > I don't think this is "advanced". It's quite natural for users to have to r Yep, it's a good point. http://gerrit.cloudera.org:8080/#/c/14351/1/src/kudu/clock/hybrid_clock.cc File src/kudu/clock/hybrid_clock.cc: http://gerrit.cloudera.org:8080/#/c/14351/1/src/kudu/clock/hybrid_clock.cc@65 PS1, Line 65: TAG_FLAG(time_source, advanced); > Likewise, this doesn't strike me as "advanced" per se, given how simple it Done -- To view, visit http://gerrit.cloudera.org:8080/14351 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic987b13b6c1eb2c886eeebaaddfc0f376e3d3954 Gerrit-Change-Number: 14351 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 02 Oct 2019 20:34:40 +0000 Gerrit-HasComments: Yes
