Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14404 )
Change subject: WIP [docs] Kudu 1.11 release notes draft ...................................................................... Patch Set 7: (22 comments) http://gerrit.cloudera.org:8080/#/c/14404/7/docs/release_notes.adoc File docs/release_notes.adoc: http://gerrit.cloudera.org:8080/#/c/14404/7/docs/release_notes.adoc@34 PS7, Line 34: * Flume 1.8+ requires Java 8 at runtime even though the Kudu Flume integration : is Java 7 compatible. Flume 1.9 is the default dependency version as of : Kudu 1.9.0. : : * Hadoop 3.0+ requires Java 8 at runtime even though the Kudu Hadoop integration : is Java 7 compatible. Hadoop 3.2 is the default dependency version as of : Kudu 1.9.0. > Should probably modify these bits too. See KUDU-2099 for more details on th Ah, great. I removed this sice Java8 is already a requirement in Kudu 1.10.0 http://gerrit.cloudera.org:8080/#/c/14404/7/docs/release_notes.adoc@48 PS7, Line 48: * `TabletLocationsPB.ReplicaPB` has been deprecated since Kudu 1.11.0 in both : {cpp} and Java Kudu clients. The server side still recognizes the : `TabletLocationsPB.ReplicaPB` message for backward compatibility with clients : of prior versions. > While accurate, we should try to describe this in concrete user-facing term Done http://gerrit.cloudera.org:8080/#/c/14404/7/docs/release_notes.adoc@52 PS7, Line 52: : * Support for Java 7 has been deprecated since Kudu 1.5.0 and may be removed in : the next major release. > Java 7 support was removed in 1.10.0. Not sure why this carried over into h Done http://gerrit.cloudera.org:8080/#/c/14404/7/docs/release_notes.adoc@59 PS7, Line 59: While a tablet : server is in maintenance, its downtime does not automatically trigger : re-replication of its replicas > Nit: perhaps "While in this mode, the tablet server's replicas will not be Done http://gerrit.cloudera.org:8080/#/c/14404/7/docs/release_notes.adoc@68 PS7, Line 68: With the built-in NTP : client enabled > Nit: "When enabled," Done http://gerrit.cloudera.org:8080/#/c/14404/7/docs/release_notes.adoc@69 PS7, Line 69: it's no longer required to keep the system clock of Kudu : nodes synchronzed with NTP (might be useful in case of containerized : deployments) > Nit: "system clock synchronization for nodes running Kudu is no longer nece The idea was to mention that the built-in NTP client might be useful for containerized deployments. http://gerrit.cloudera.org:8080/#/c/14404/7/docs/release_notes.adoc@71 PS7, Line 71: With the built-in NTP client enabled, the internal wallclock : is synchronized with NTP servers specified with the `--builtin_ntp_servers` : flag. By default, the built-in NTP client uses public servers of the : `pool.ntp.org` project > Nit: "The list of NTP servers to synchronize against is specified with the Done http://gerrit.cloudera.org:8080/#/c/14404/7/docs/release_notes.adoc@75 PS7, Line 75: `0.pool.ntp.org,1.pool.ntp.org,2.pool.ntp.org,3.pool.ntp.org` > I don't think we need to get this specific; just referencing pool.ntp.org i Done http://gerrit.cloudera.org:8080/#/c/14404/7/docs/release_notes.adoc@75 PS7, Line 75: To switch Kudu : masters and tablet servers to use the built-in NTP client, add : `--time_source=builtin` into the set of their flags, customizing the : `--builtin_ntp_servers` flag if necessary : (see link:https://issues.apache.org/jira/browse/KUDU-2935[KUDU-2935]). : > Nit: "To use the built-in NTP client, set `--time_source=builtin` and recon Done http://gerrit.cloudera.org:8080/#/c/14404/7/docs/release_notes.adoc@81 PS7, Line 81: via : GetTableStatistics master's RPC > Let's refer to specific APIs rather than to RPCs, as users interact with th Done http://gerrit.cloudera.org:8080/#/c/14404/7/docs/release_notes.adoc@87 PS7, Line 87: uuid > Should we surround this with triangular brackets to emphasize that it's not Done http://gerrit.cloudera.org:8080/#/c/14404/7/docs/release_notes.adoc@91 PS7, Line 91: * The `kudu` CLI tool now supports altering and dropping table columns. Using : the newly introduced `kudu table delete_column` sub-command, it's possible to : drop a column of the specified table. The newly introduced commands such as : `kudu table column_set_default`, `kudu table column_remove_default`, : `kudu table column_set_compression`, `kudu table column_set_encoding`, : and `kudu table column_set_block_size` allows for altering a column of the : specified table correspondingly. > Given the asymmetry between these two (unlike the other new CLI tools below Done http://gerrit.cloudera.org:8080/#/c/14404/7/docs/release_notes.adoc@119 PS7, Line 119: tablet server > Probably drop, as it affects masters too. Done http://gerrit.cloudera.org:8080/#/c/14404/7/docs/release_notes.adoc@126 PS7, Line 126: Tablet server > Isn't this for the master web ui? Whoops, indeed. Good catch! http://gerrit.cloudera.org:8080/#/c/14404/7/docs/release_notes.adoc@129 PS7, Line 129: groups > singular Done http://gerrit.cloudera.org:8080/#/c/14404/7/docs/release_notes.adoc@130 PS7, Line 130: that tablet's > replace with "the" Done http://gerrit.cloudera.org:8080/#/c/14404/7/docs/release_notes.adoc@133 PS7, Line 133: Kudu > "the Kudu" Done http://gerrit.cloudera.org:8080/#/c/14404/7/docs/release_notes.adoc@153 PS7, Line 153: * Tablet servers now consider the available space when selecting data : directories for tablets and blocks > How about "Tablet servers now consider available disk space when choosing a Done http://gerrit.cloudera.org:8080/#/c/14404/7/docs/release_notes.adoc@163 PS7, Line 163: constrains > constraints Done http://gerrit.cloudera.org:8080/#/c/14404/7/docs/release_notes.adoc@164 PS7, Line 164: The previous behavior was to reject the whole batch of write : operations if a violation of the schema constraints is detected even : for a single row > Do we need to surface this as an upgrade note? Done http://gerrit.cloudera.org:8080/#/c/14404/7/docs/release_notes.adoc@169 PS7, Line 169: to > Replace with "with a" Done http://gerrit.cloudera.org:8080/#/c/14404/7/docs/release_notes.adoc@170 PS7, Line 170: use > "Use the foo and bar methods of the C++ and Java Kudu clients." Done -- To view, visit http://gerrit.cloudera.org:8080/14404 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I201f4e07504d59e668b99d6154c9412ed79c9d35 Gerrit-Change-Number: 14404 Gerrit-PatchSet: 7 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Greg Solovyev <gsolov...@cloudera.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Volodymyr Verovkin <verjov...@cloudera.com> Gerrit-Reviewer: Yao Xu <ocla...@gmail.com> Gerrit-Reviewer: honeyhexin <honeyhe...@sohu.com> Gerrit-Comment-Date: Fri, 11 Oct 2019 08:10:24 +0000 Gerrit-HasComments: Yes
