Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14419 )
Change subject: util: gscoped_ptr<ThreadPool> -> unique_ptr<ThreadPool> ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/14419/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14419/1//COMMIT_MSG@15 PS1, Line 15: are no funct > It sounds like you are not quite sure? :) :) http://gerrit.cloudera.org:8080/#/c/14419/1/src/kudu/util/threadpool.cc File src/kudu/util/threadpool.cc: http://gerrit.cloudera.org:8080/#/c/14419/1/src/kudu/util/threadpool.cc@128 PS1, Line 128: return (*pool)->Init(); : } > nit: while you are at it, maybe you could merge these two lines into Done -- To view, visit http://gerrit.cloudera.org:8080/14419 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia69a079cf9bf834f4a626b6771442b84c7a37983 Gerrit-Change-Number: 14419 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Volodymyr Verovkin <[email protected]> Gerrit-Comment-Date: Sat, 12 Oct 2019 01:30:38 +0000 Gerrit-HasComments: Yes
