Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14436 )
Change subject: ksck: print tablet server states ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/14436/3/src/kudu/tools/ksck_remote.cc File src/kudu/tools/ksck_remote.cc: http://gerrit.cloudera.org:8080/#/c/14436/3/src/kudu/tools/ksck_remote.cc@511 PS3, Line 511: : vector<KuduTabletServer*> servers; : ElementDeleter deleter(&servers); : RETURN_NOT_OK(client_->ListTabletServers(&servers)); Don't need this anymore? http://gerrit.cloudera.org:8080/#/c/14436/3/src/kudu/tools/ksck_remote.cc@522 PS3, Line 522: InsertOrUpdate(&ts_states, uuid, ts_pb.state()); Why not EmplaceOrDie here? -- To view, visit http://gerrit.cloudera.org:8080/14436 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4cec8c85a08bcb4f7be9e98a34d4b5ae2f05f3be Gerrit-Change-Number: 14436 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 15 Oct 2019 20:57:28 +0000 Gerrit-HasComments: Yes
