Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14484 )
Change subject: WIP: fix wrong value of live_row_count ...................................................................... Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/14484/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14484/1//COMMIT_MSG@15 PS1, Line 15: *need to add tests. Yes. We should have added one for the last fix too. http://gerrit.cloudera.org:8080/#/c/14484/1//COMMIT_MSG@16 PS1, Line 16: *need to fix merge metric bug. What is this alluding to? http://gerrit.cloudera.org:8080/#/c/14484/1/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/14484/1/src/kudu/master/catalog_manager.cc@5580 PS1, Line 5580: // Some tablet of the table dosen't support live row counting. "This tablet doesn't support live row counting, so we disable it for the entire table". http://gerrit.cloudera.org:8080/#/c/14484/1/src/kudu/master/table_metrics.cc File src/kudu/master/table_metrics.cc: http://gerrit.cloudera.org:8080/#/c/14484/1/src/kudu/master/table_metrics.cc@31 PS1, Line 31: "When some tablet of the table doesn't support live row counting, -1 will be returned."); Rephrase as "If even one tablet of the table doesn't support live row counting, -1 will be returned." -- To view, visit http://gerrit.cloudera.org:8080/14484 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I757978cb496d47306f91ea251cba00bde7929e36 Gerrit-Change-Number: 14484 Gerrit-PatchSet: 1 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 17 Oct 2019 18:23:03 +0000 Gerrit-HasComments: Yes
