Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14468 )
Change subject: master: fix the value of table metric 'live_row_count' ...................................................................... master: fix the value of table metric 'live_row_count' When the tablet doesn't support live row counting, the 'live_row_count' metric of the tablet is '-1'. But when master aggregates all tablets' metric of a table, it sums up all '-1's, and the result value is confusing to users. It's better to set it '-1' to be consistent with tablet metric. Change-Id: I3f837466a0420dafef4f9426929b7b1622702ffc Reviewed-on: http://gerrit.cloudera.org:8080/14446 Tested-by: Kudu Jenkins Reviewed-by: Yingchun Lai <[email protected]> Reviewed-by: Alexey Serbin <[email protected]> (cherry picked from commit d525c11d441143eeb40389ab920f5f651ddff54f) Reviewed-on: http://gerrit.cloudera.org:8080/14468 Tested-by: Alexey Serbin <[email protected]> Reviewed-by: Grant Henke <[email protected]> --- M src/kudu/master/catalog_manager.cc M src/kudu/master/table_metrics.cc 2 files changed, 8 insertions(+), 2 deletions(-) Approvals: Alexey Serbin: Verified Yingchun Lai: Looks good to me, but someone else must approve Grant Henke: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/14468 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.11.x Gerrit-MessageType: merged Gerrit-Change-Id: I3f837466a0420dafef4f9426929b7b1622702ffc Gerrit-Change-Number: 14468 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]>
