Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14440 )
Change subject: webserver: enable HTTP keep-alive ...................................................................... Patch Set 6: (5 comments) http://gerrit.cloudera.org:8080/#/c/14440/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14440/6//COMMIT_MSG@12 PS6, Line 12: keep-alive is assumed > nit: maybe, add a reference to that, like https://tools.ietf.org/html/rfc20 That's not quite the right section of the reference though. Plus I'm quoting from IMPALA-8869 so I'd like to keep that quote pristine. http://gerrit.cloudera.org:8080/#/c/14440/6/src/kudu/server/webserver.cc File src/kudu/server/webserver.cc: http://gerrit.cloudera.org:8080/#/c/14440/6/src/kudu/server/webserver.cc@601 PS6, Line 601: stringstream > nit: ostringstream ? All the mustache code paths using stringstream because that's what mustache's RenderTemplate function expects. I even teed up a patch in mustache to replace stringstream with ostringstream before realizing that Impala uses stringstreams almost exclusively, so such a patch, while nice for Kudu, would be frustrating for Impala. http://gerrit.cloudera.org:8080/#/c/14440/6/src/kudu/server/webserver.cc@682 PS6, Line 682: stringstream > nit: ostringstream ? Ack http://gerrit.cloudera.org:8080/#/c/14440/6/src/kudu/server/webserver.cc@757 PS6, Line 757: stringstream > nit: ostringstream ? Ack http://gerrit.cloudera.org:8080/#/c/14440/6/src/kudu/server/webserver.cc@777 PS6, Line 777: stringstream > nit: ostringstream ? Ack -- To view, visit http://gerrit.cloudera.org:8080/14440 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic08ef5a268fdf6dea6a8c428b4ab8dac27418dd6 Gerrit-Change-Number: 14440 Gerrit-PatchSet: 6 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Fri, 18 Oct 2019 03:29:45 +0000 Gerrit-HasComments: Yes
