Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/13760 )
Change subject: KUDU-1938 Add support for VARCHAR pt 1 ...................................................................... Patch Set 33: (1 comment) http://gerrit.cloudera.org:8080/#/c/13760/33/src/kudu/util/char_util.cc File src/kudu/util/char_util.cc: http://gerrit.cloudera.org:8080/#/c/13760/33/src/kudu/util/char_util.cc@29 PS33, Line 29: num_utf8_chars += (*str++ & 0xc0) != 0x80; > OK, I see you added tests for this in the "make UTF8Truncate faster" patche Actually this was a result of a botched refactor. When I removed the code relevant to CHAR type I mess it up and removed the code which advanced this iterator. If you compare it to PS31 you'll see that in L37 there was an additional condition where the iterator was advanced. When I removed that part as it wasn't needed anymore I forgot to change *str to *str++ here. There are tests in partial_row-test.cc which caught this. There are also more test coverage in follow-up commits as you noted. -- To view, visit http://gerrit.cloudera.org:8080/13760 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I998982dba93831db91c43a97ce30d3e68c2a4a54 Gerrit-Change-Number: 13760 Gerrit-PatchSet: 33 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Tue, 22 Oct 2019 19:16:00 +0000 Gerrit-HasComments: Yes
