Attila Bukor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13928 )
Change subject: KUDU-1938 Add non-copy VARCHAR setters pt 3 ...................................................................... KUDU-1938 Add non-copy VARCHAR setters pt 3 Apache Impala uses KuduPartialRow API to determine which partition a row will be inserted to distribute the data between executors optimally. For this purpose the copy is unnecessary and it should be fast. This commit adds NoCopyUnsafe variants for this purpose which expect the data to already be truncated (which it is in Impala's case) and only check that the value's length is lower than the highest possible upper bound: val.size() < max_length*4 bytes (the maximum size of an UTF8 character) to avoid having to count each character manually. Change-Id: I1f2aba098d649eb94e0314f6606cc33600e8d766 Reviewed-on: http://gerrit.cloudera.org:8080/13928 Reviewed-by: Adar Dembo <[email protected]> Reviewed-by: Grant Henke <[email protected]> Tested-by: Kudu Jenkins --- M src/kudu/common/partial_row-test.cc M src/kudu/common/partial_row.cc M src/kudu/common/partial_row.h 3 files changed, 88 insertions(+), 0 deletions(-) Approvals: Adar Dembo: Looks good to me, approved Grant Henke: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/13928 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I1f2aba098d649eb94e0314f6606cc33600e8d766 Gerrit-Change-Number: 13928 Gerrit-PatchSet: 24 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]>
