Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14534 )
Change subject: [metrics] Hide metric live_row_count when tablet not support ...................................................................... [metrics] Hide metric live_row_count when tablet not support When upgrade an tserver from version older than 1.11, and add some partitions for an existing table, then the table will hold some tablets that support live row counting together with some ones that not support. Tablet which not support live row counting has value of -1, in this case, metrics merge on tserver and metrics aggregate on master have problems. This patch add feature to validate metric when happend to see an invalid metric when MergeFrom, and disable 'live_row_count' metric of a table when any tablet of a table not support live rows counting on master. Change-Id: I2a54704d8cbd64a521e65aa3e95bf1a68f7757b7 Reviewed-on: http://gerrit.cloudera.org:8080/14507 Reviewed-by: Adar Dembo <[email protected]> Tested-by: Kudu Jenkins (cherry picked from commit 67fbb7c0367e12629da8a14a21362c0e256e1f89) Reviewed-on: http://gerrit.cloudera.org:8080/14534 Reviewed-by: Alexey Serbin <[email protected]> --- M src/kudu/integration-tests/ts_tablet_manager-itest.cc M src/kudu/master/catalog_manager.cc M src/kudu/master/catalog_manager.h M src/kudu/master/master_path_handlers.cc M src/kudu/master/table_metrics.cc M src/kudu/master/table_metrics.h M src/kudu/tablet/compaction-test.cc M src/kudu/tablet/diskrowset.cc M src/kudu/tablet/diskrowset.h M src/kudu/tablet/memrowset-test.cc M src/kudu/tablet/memrowset.h M src/kudu/tablet/metadata.proto M src/kudu/tablet/mock-rowsets.h M src/kudu/tablet/mt-tablet-test.cc M src/kudu/tablet/rowset.cc M src/kudu/tablet/rowset.h M src/kudu/tablet/tablet-test.cc M src/kudu/tablet/tablet.cc M src/kudu/tablet/tablet.h M src/kudu/tablet/tablet_replica-test.cc M src/kudu/tablet/tablet_replica.cc M src/kudu/tablet/tablet_replica.h M src/kudu/tserver/ts_tablet_manager.cc M src/kudu/tserver/tserver_path_handlers.cc M src/kudu/util/metrics.cc M src/kudu/util/metrics.h 26 files changed, 269 insertions(+), 110 deletions(-) Approvals: Kudu Jenkins: Verified Alexey Serbin: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/14534 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.11.x Gerrit-MessageType: merged Gerrit-Change-Id: I2a54704d8cbd64a521e65aa3e95bf1a68f7757b7 Gerrit-Change-Number: 14534 Gerrit-PatchSet: 2 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]>
