Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14535 )
Change subject: scripts: multi-master support for start_kudu.sh and stop_kudu.sh ...................................................................... Patch Set 1: (3 comments) few nits http://gerrit.cloudera.org:8080/#/c/14535/1/src/kudu/scripts/start_kudu.sh File src/kudu/scripts/start_kudu.sh: http://gerrit.cloudera.org:8080/#/c/14535/1/src/kudu/scripts/start_kudu.sh@31 PS1, Line 31: -h, --help help : -m, --num-masters Number of Kudu Master servers to start (default: 1) : -t, --num-tservers Number of Kudu Tablet Servers to start (default: 3) : --rpc-master RPC port of first Kudu Master server (HTTP port is next number) : --rpc-tserver RPC port of first Kudu Tablet Server (other servers : will have following numbers) : -b, --builddir path to the Kudu build directory nit: align the description of the parameters? http://gerrit.cloudera.org:8080/#/c/14535/1/src/kudu/scripts/stop_kudu.sh File src/kudu/scripts/stop_kudu.sh: http://gerrit.cloudera.org:8080/#/c/14535/1/src/kudu/scripts/stop_kudu.sh@25 PS1, Line 25: TSERVERS="$(pgrep -d ' ' kudu-tserver)" : if [ -n "$TSERVERS" ]; then : echo "Killing tservers: $TSERVERS" : kill -9 $TSERVERS : fi If relying on pgrep, pkill comes along as well. Maybe, simply do pkill -9 -u $(id -u) -x kudu-tserver here? http://gerrit.cloudera.org:8080/#/c/14535/1/src/kudu/scripts/stop_kudu.sh@30 PS1, Line 30: MASTERS="$(pgrep -d ' ' kudu-master)" : if [ -n "$MASTERS" ]; then : echo "Killing masters: $MASTERS" : kill -9 $MASTERS : fi ditto: pkill -9 -u $(id -u) -x kudu-master -- To view, visit http://gerrit.cloudera.org:8080/14535 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id8db19c9145b5c68bb437390e6c0608961680347 Gerrit-Change-Number: 14535 Gerrit-PatchSet: 1 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Volodymyr Verovkin <[email protected]> Gerrit-Comment-Date: Wed, 23 Oct 2019 22:06:03 +0000 Gerrit-HasComments: Yes
