Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14541 )
Change subject: [scripts] a tool to print out HybridTime timestamps ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/14541/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14541/1//COMMIT_MSG@10 PS1, Line 10: (works with Python2) Support for python2 is ending soon, so it'd be worth making new scripts work with both. http://gerrit.cloudera.org:8080/#/c/14541/1/src/kudu/scripts/convert-hybrid-timestamp.py File src/kudu/scripts/convert-hybrid-timestamp.py: http://gerrit.cloudera.org:8080/#/c/14541/1/src/kudu/scripts/convert-hybrid-timestamp.py@40 PS1, Line 40: print This is problematic for python3. Can use print() function to be compatible with python2 and 3 by using following import. `from __future__ import print_function` -- To view, visit http://gerrit.cloudera.org:8080/14541 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifc5b0d20c6f1bca0994d00a347ff14e4ae64a14c Gerrit-Change-Number: 14541 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 24 Oct 2019 17:52:33 +0000 Gerrit-HasComments: Yes
