Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14554 )
Change subject: Revert "Revert "KUDU-2356. Idle WALs should not consume significant memory"" ...................................................................... Patch Set 4: > Patch Set 4: Code-Review+2 > > Normally I'd ask whether we can stop depending on an unsafe method like > AllocateSegmentAndRollover (especially since the production path is so > different), but that looks like it'd add more complexity than it's worth. Yeah, it's intertwined in quite a few tests unfortunately. Maybe it'll be easier to do that after my refactoring patch lands, but for now, I wouldn't gate this bugfix on it. -- To view, visit http://gerrit.cloudera.org:8080/14554 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I571a7cb3d310687e6e22bbd547e51a2ea81b8806 Gerrit-Change-Number: 14554 Gerrit-PatchSet: 4 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Mon, 28 Oct 2019 04:24:47 +0000 Gerrit-HasComments: No
