Hello Alexey Serbin, Attila Bukor,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/14557
to review the following change.
Change subject: schema.h: fix compilation with old gcc
......................................................................
schema.h: fix compilation with old gcc
This file fails to compile with the system gcc found on CentOS 6.6
(version 4.4.7) with the following error:
kudu/client/schema.h:115: error: a class-key must be used when declaring a
friend
kudu/client/schema.h:115: error: friend declaration does not name a class or
function
kudu/client/schema.h:116: error: a class-key must be used when declaring a
friend
kudu/client/schema.h:116: error: friend declaration does not name a class or
function
kudu/client/schema.h:117: error: a class-key must be used when declaring a
friend
kudu/client/schema.h:117: error: friend declaration does not name a class or
function
It's a regression from commit 4343fb746. What's perplexing is that while
it's reliably showing up in the dist-test dashboard as a
client_examples-test.sh failure, it's not reliably reproducible. When I'm
logged into a CentOS 6.6 machine I can repro the failed g++ attempt, but if
I run the failed test itself, it passes.
Change-Id: I5916501fc52910bcc0e843726a1d684be6d56417
---
M src/kudu/client/schema.h
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/57/14557/1
--
To view, visit http://gerrit.cloudera.org:8080/14557
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5916501fc52910bcc0e843726a1d684be6d56417
Gerrit-Change-Number: 14557
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Attila Bukor <[email protected]>
