Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14567 )
Change subject: KUDU-2986 p1: adjust the output of "table statistics" from 0 -> N/A ...................................................................... Patch Set 1: (1 comment) Could you add a unit test for the new behavior? http://gerrit.cloudera.org:8080/#/c/14567/1/src/kudu/client/table_statistics-internal.h File src/kudu/client/table_statistics-internal.h: http://gerrit.cloudera.org:8080/#/c/14567/1/src/kudu/client/table_statistics-internal.h@47 PS1, Line 47: if (live_row_count_) { : display_string += Substitute("live row count: $0\n", *live_row_count_); : } else { : display_string += Substitute("live row count: N/A\n"); : } Rewrite as a ternary: display_string += Substitute("live row count: $0\n", live_row_count_ ? std::to_string(*live_row_count_) : "N/A"); -- To view, visit http://gerrit.cloudera.org:8080/14567 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I82c47f5ac07cf63d455c0720614c5383bfa88ca3 Gerrit-Change-Number: 14567 Gerrit-PatchSet: 1 Gerrit-Owner: helifu <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 29 Oct 2019 16:30:16 +0000 Gerrit-HasComments: Yes
