Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14569 )
Change subject: util: add ToLowerCase string case methods ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/14569/1/src/kudu/util/string_case.h File src/kudu/util/string_case.h: http://gerrit.cloudera.org:8080/#/c/14569/1/src/kudu/util/string_case.h@46 PS1, Line 46: Lower-case nit: while you are at it, could you add that this is about ASCII upper/lower characters? http://gerrit.cloudera.org:8080/#/c/14569/1/src/kudu/util/string_case.cc File src/kudu/util/string_case.cc: http://gerrit.cloudera.org:8080/#/c/14569/1/src/kudu/util/string_case.cc@70 PS1, Line 70: ascii_tolower Is it OK to ignore locale and just use ASCII conversion instead? -- To view, visit http://gerrit.cloudera.org:8080/14569 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3d9ddb28175a328dbd23549bee527c33f7a519b8 Gerrit-Change-Number: 14569 Gerrit-PatchSet: 1 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 29 Oct 2019 20:20:23 +0000 Gerrit-HasComments: Yes
