[email protected] has posted comments on this change. ( http://gerrit.cloudera.org:8080/14587 )
Change subject: [compression] Use new lz4 API ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/14587/1/src/kudu/util/compression/compression_codec.cc File src/kudu/util/compression/compression_codec.cc: http://gerrit.cloudera.org:8080/#/c/14587/1/src/kudu/util/compression/compression_codec.cc@184 PS1, Line 184: if (n != uncompressed_length) { > Are you sure comparing against uncompressed_length makes sense? Seems like Yes, the `uncompressed_length` was stored in CFile Block Header when the cfile block was compressed(in CompressedBlockBuilder::Compress()), So here, `uncompressed_length` must be exactly equal to the size after decompression. -- To view, visit http://gerrit.cloudera.org:8080/14587 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib343fda7fff1d14ee7bc551be3ac87b068504359 Gerrit-Change-Number: 14587 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 31 Oct 2019 03:30:39 +0000 Gerrit-HasComments: Yes
