Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/14573 )
Change subject: webserver: add support for Knox URL rewriting ...................................................................... Patch Set 5: Code-Review+1 (4 comments) all makes sense to me http://gerrit.cloudera.org:8080/#/c/14573/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14573/5//COMMIT_MSG@76 PS5, Line 76: But it's also fraught in that Impala : doesn't always know its own hostname Fwiw, we basically get around this by expected that users may need to set something like '--hostname' to get everything to work. Maybe not ideal, but since we have links between daemons, and Knox can't really rewrite those with $inboundurl, we have to have some way for every daemon to determine a Knox-acceptable hostname anyways. I think your approach is perfectly reasonable too, and no reason to change it now, but I think you have the same issue of links between daemons and you might need to think about how those are generated. http://gerrit.cloudera.org:8080/#/c/14573/5/src/kudu/server/webserver.cc File src/kudu/server/webserver.cc: http://gerrit.cloudera.org:8080/#/c/14573/5/src/kudu/server/webserver.cc@750 PS5, Line 750: {{base_url}}{{path}} '/'? http://gerrit.cloudera.org:8080/#/c/14573/5/www/home.mustache File www/home.mustache: http://gerrit.cloudera.org:8080/#/c/14573/5/www/home.mustache@22 PS5, Line 22: {{base_url}}{{path}} should there be a '/' between these? http://gerrit.cloudera.org:8080/#/c/14573/5/www/tablets.mustache File www/tablets.mustache: http://gerrit.cloudera.org:8080/#/c/14573/5/www/tablets.mustache@51 PS5, Line 51: {{base_url}}{{url}} '/'? -- To view, visit http://gerrit.cloudera.org:8080/14573 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iee92cb094b81609356acf858b7c549b6c281a7e5 Gerrit-Change-Number: 14573 Gerrit-PatchSet: 5 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 31 Oct 2019 18:59:33 +0000 Gerrit-HasComments: Yes
