Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/14598 )
Change subject: [spark] Add prefetching option to kudu-spark ...................................................................... Patch Set 1: > (1 comment) > > Thanks for finding and fixing this bug. Could we break this into > two patches for clarity? The first patch should fix exposing > prefetching in the scan token, and the second should expose > prefetching to spark. Ok, I will break this patch into two patches. I think it's better to set it to false for the time being, because prefetching means that the spark task needs more memory, which may cause problems for the stability of existing spark jobs, such as memory out of limits. -- To view, visit http://gerrit.cloudera.org:8080/14598 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If48735d693ad560f96e8cd5781eff916c06b8aa8 Gerrit-Change-Number: 14598 Gerrit-PatchSet: 1 Gerrit-Owner: Yao Xu <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yao Xu <[email protected]> Gerrit-Comment-Date: Fri, 01 Nov 2019 07:59:01 +0000 Gerrit-HasComments: No
