Andrew Wong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12868 )

Change subject: RELEASING: add instructions to create binary test JARs
......................................................................


Patch Set 2: Code-Review+2

(3 comments)

Couple of grammar nits, otherwise LGTM

http://gerrit.cloudera.org:8080/#/c/12868/1/RELEASING.adoc
File RELEASING.adoc:

http://gerrit.cloudera.org:8080/#/c/12868/1/RELEASING.adoc@171
PS1, Line 171: uild a binary JAR for the local operating system. The result JAR 
is output
             :   # into the build/mini-cluster directory.
             :   ./build-support/mini-cluster/build_
> Done.
Gotcha, thanks for clarifying!


http://gerrit.cloudera.org:8080/#/c/12868/2/RELEASING.adoc
File RELEASING.adoc:

http://gerrit.cloudera.org:8080/#/c/12868/2/RELEASING.adoc@171
PS2, Line 171: result
nit: resulting


http://gerrit.cloudera.org:8080/#/c/12868/2/RELEASING.adoc@174
PS2, Line 174: m b
nit: the build/mini-cluster directory



--
To view, visit http://gerrit.cloudera.org:8080/12868
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9c0419b666fe8dfa9394136962189eee97af2d38
Gerrit-Change-Number: 12868
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Percy <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Grant Henke <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <[email protected]>
Gerrit-Comment-Date: Fri, 01 Nov 2019 19:04:57 +0000
Gerrit-HasComments: Yes

Reply via email to