Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14479 )
Change subject: log: separate out allocation logic ...................................................................... Patch Set 6: (5 comments) http://gerrit.cloudera.org:8080/#/c/14479/5/src/kudu/consensus/log.cc File src/kudu/consensus/log.cc: http://gerrit.cloudera.org:8080/#/c/14479/5/src/kudu/consensus/log.cc@508 PS5, Line 508: ctx.metrics.reset(metric_entity ? new LogMetrics(metric_entity) : nullptr); > warning: std::move of the variable 'options' of the trivially-copyable type Ack http://gerrit.cloudera.org:8080/#/c/14479/5/src/kudu/consensus/log.cc@516 PS5, Line 516: > warning: std::move of the variable 'options' of the trivially-copyable type Ack http://gerrit.cloudera.org:8080/#/c/14479/5/src/kudu/consensus/log.cc@1163 PS5, Line 1163: RETURN_NOT_OK_PREPEND(reader_add_segment_(std::move(readable_segment)), "add"); > warning: prefer ptr1 = std::move(ptr2) over ptr1.reset(ptr2.release()) [mis Done http://gerrit.cloudera.org:8080/#/c/14479/5/src/kudu/consensus/log.cc@1188 PS5, Line 1188: > warning: passing result of std::move() as a const reference argument; no mo Done http://gerrit.cloudera.org:8080/#/c/14479/5/src/kudu/consensus/log.cc@1193 PS5, Line 1193: > warning: passing result of std::move() as a const reference argument; no mo Done -- To view, visit http://gerrit.cloudera.org:8080/14479 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I08be4dbdd8e98b02278de76273e931c314b08161 Gerrit-Change-Number: 14479 Gerrit-PatchSet: 6 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Sun, 03 Nov 2019 06:44:53 +0000 Gerrit-HasComments: Yes
