Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/14603 )
Change subject: [spark] Add a test for sink based writing ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/14603/1/java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala File java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala: http://gerrit.cloudera.org:8080/#/c/14603/1/java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala@349 PS1, Line 349: .format("kudu") : .option("kudu.master", harness.getMasterAddressesAsString) : .option("kudu.table", tableName) : .mode(SaveMode.Append) : .save() > nit: could you add a comment explaining why that we don't need to supply "k Will do. http://gerrit.cloudera.org:8080/#/c/14603/1/java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala@365 PS1, Line 365: .mode(SaveMode.Append) > Do the other save modes work? If they do, maybe test them too? No, currently we error if the mode isn't append here: https://github.com/apache/kudu/blob/master/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala#L142 -- To view, visit http://gerrit.cloudera.org:8080/14603 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic1f28be80ad21b0783d8a0889ad7b1847601442b Gerrit-Change-Number: 14603 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 06 Nov 2019 22:15:41 +0000 Gerrit-HasComments: Yes
