Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14650 )
Change subject: wip KUDU-2929: don't do nothing when under memory pressure ...................................................................... Patch Set 1: (1 comment) > Patch Set 1: > > (1 comment) > > Any way to unit test this? Maybe via some mocking in > maintenance_manager-test.cc? Sure, should be able to test that we schedule _something_ instead of nothing, even if there's no MRS or DMS. http://gerrit.cloudera.org:8080/#/c/14650/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14650/1//COMMIT_MSG@19 PS1, Line 19: let's continue walking through valid ops. > Might want to add here what you'd expect to happen (i.e. now we'll do compa It won't necessarily be compaction. It'll be whatever has we would do next if we weren't under memory pressure. -- To view, visit http://gerrit.cloudera.org:8080/14650 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I030f9ef379af501fe7bd2f42906ec2f9ea16dbde Gerrit-Change-Number: 14650 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 07 Nov 2019 04:56:30 +0000 Gerrit-HasComments: Yes
