Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14651 )
Change subject: [cfile] not_null -> is_null ...................................................................... [cfile] not_null -> is_null In a bitmap, we use `true` to represent `null`. So when we iterate over a bitmap, if it returns `true`, its meaning is "it is a null" In the original implementation, it was incorrectly named `not_null` Change-Id: I836ebce2eae6f8df18ec256b000fee23fd62ce3e Reviewed-on: http://gerrit.cloudera.org:8080/14651 Tested-by: Kudu Jenkins Reviewed-by: Adar Dembo <[email protected]> --- M src/kudu/cfile/cfile_writer.cc M src/kudu/cfile/cfile_writer.h 2 files changed, 11 insertions(+), 10 deletions(-) Approvals: Kudu Jenkins: Verified Adar Dembo: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/14651 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I836ebce2eae6f8df18ec256b000fee23fd62ce3e Gerrit-Change-Number: 14651 Gerrit-PatchSet: 3 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120)
