Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14654 )
Change subject: [KUDU-2975]Spread WAL across multiple directories ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/14654/3/src/kudu/fs/data_dirs.cc File src/kudu/fs/data_dirs.cc: http://gerrit.cloudera.org:8080/#/c/14654/3/src/kudu/fs/data_dirs.cc@723 PS3, Line 723: if (opts_.dir_type == "data") { : // Create a per-dir thread pool. > This style of checking makes the code more difficult to understand and main Andrew and I discussed this at length today. We agreed that there's both enough overlapping and non-overlapping functionality that either approach (sharing a common directory manager implementation or two different implementations) is going to require some work. Given that this patch instantiates two different DataDirManagers, I'm inclined to agree with Andrew that perhaps we should start with two completely different classes (one for managing data directories and one for managing WAL directories), and see where that takes us. -- To view, visit http://gerrit.cloudera.org:8080/14654 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ied496804421d91ff1fa63d49979fde971071506e Gerrit-Change-Number: 14654 Gerrit-PatchSet: 3 Gerrit-Owner: YangSong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: YangSong <[email protected]> Gerrit-Comment-Date: Fri, 08 Nov 2019 22:59:51 +0000 Gerrit-HasComments: Yes
