[email protected] has posted comments on this change. ( http://gerrit.cloudera.org:8080/14652 )
Change subject: KUDU-2162 Expose stats about scan filters ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/14652/1/src/kudu/tserver/tablet_service.cc File src/kudu/tserver/tablet_service.cc: http://gerrit.cloudera.org:8080/#/c/14652/1/src/kudu/tserver/tablet_service.cc@1611 PS1, Line 1611: > Nit: don't need this extra space. Done http://gerrit.cloudera.org:8080/#/c/14652/1/src/kudu/tserver/tablet_service.cc@1622 PS1, Line 1622: context->trace()->metrics()->GetMetric(SCANNER_BYTES_READ_METRIC_NAME)); : : MonoDelta duration = scan_metrics.GetScanDurationAndTimeSinceStart(ScanState::kActive).first; : metrics->set_duration_nanos(duration.ToNanoseconds()); : metrics->set_cpu_system_nanos(scan_metrics.cpu_times.system); : metrics->set_cpu_user_nanos(scan_metrics.cpu_times.user); : m > This was copied from tserver_path_handlers.cc; could you decompose it into Done http://gerrit.cloudera.org:8080/#/c/14652/2/src/kudu/tserver/tablet_service.cc File src/kudu/tserver/tablet_service.cc: http://gerrit.cloudera.org:8080/#/c/14652/2/src/kudu/tserver/tablet_service.cc@1613 PS2, Line 1613: void SetResourceMetrics(rpc::RpcContext* context, > There are some short-circuit paths that return OK but don't populate the Sc In the GetScanDurationAndTimeSinceStart() is set to 0 if the start_time or last_access_time is not initialized. The cpu time metrics are also initialized to zero. http://gerrit.cloudera.org:8080/#/c/14652/2/src/kudu/tserver/tablet_service.cc@2692 PS2, Line 2692: *has_more_results = !req->close_scanner() && iter->HasNext() && > This makes a copy of the ScanDescriptor with each Scan RPC. That's somewhat I moved the metrics from ScanDescriptor into a new ScanMetrics struct. I also added a ScanMetrics field to ScanResultCollector so that we don't have to pass an additional param to HandleNewScanRequest and HandleContinueScanRequest. -- To view, visit http://gerrit.cloudera.org:8080/14652 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I127b96a30467ea0abcaf6ed5b4d72df66b2dec55 Gerrit-Change-Number: 14652 Gerrit-PatchSet: 3 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Sat, 09 Nov 2019 06:43:07 +0000 Gerrit-HasComments: Yes
