Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14685 )
Change subject: WIP: KUDU-2994: don't use mini_chrony in kudu-binary ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/14685/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14685/2//COMMIT_MSG@17 PS2, Line 17: To fix this, let's further condition mini_chrony usage in the minicluster : framework on whether the chrony binaries are available or not. Thank you for for putting together this patch. What do you think if we simply don't enable built-in NTP client for the binaries in kudu-binary artifact since we cannot distribute chrony? I'm not sure that switching the condition for using system/built-in NTP should automatically change depending on whether chronyd is present. I.e., it could happen that chrony binary will be gone and would not notice some time. -- To view, visit http://gerrit.cloudera.org:8080/14685 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2d503634acf837eb3066851dfe9b942e61a77b34 Gerrit-Change-Number: 14685 Gerrit-PatchSet: 2 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 11 Nov 2019 04:08:19 +0000 Gerrit-HasComments: Yes
