Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14683 )
Change subject: docs: additional instructions for installing memkind from source ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/14683/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14683/2//COMMIT_MSG@11 PS2, Line 11: Using the default prefix (/usr/local) means Kudu won't find the library. > Maybe, we could add instructions to specify LD_LIBRARY_PATH and have the ne I don't know. Personally I view LD_LIBRARY_PATH as a security risk given its permissiveness, not to mention how would you configure Kudu's standard config files (e.g. /etc/kudu/conf/tserver.gflagfile) to incorporate it? http://gerrit.cloudera.org:8080/#/c/14683/2/docs/installation.adoc File docs/installation.adoc: http://gerrit.cloudera.org:8080/#/c/14683/2/docs/installation.adoc@116 PS2, Line 116: $ sudo yum install memkind > Does the order between installing memkind and installing numa matter? No, and in fact we don't mention the numa packages if memkind is being installed from package as the memkind package properly expresses a dependency on the libnuma package. http://gerrit.cloudera.org:8080/#/c/14683/2/docs/installation.adoc@127 PS2, Line 127: $ sudo make install > Is it going to overwrite the existing files (libraries, etc.) of already in Sure, I can add that. http://gerrit.cloudera.org:8080/#/c/14683/2/docs/installation.adoc@272 PS2, Line 272: yum > apt-get? Whoops. -- To view, visit http://gerrit.cloudera.org:8080/14683 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7d52d02ad87a27e5fef5ba5c0ab8932128a29762 Gerrit-Change-Number: 14683 Gerrit-PatchSet: 2 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 12 Nov 2019 07:10:58 +0000 Gerrit-HasComments: Yes
