Hello Kudu Jenkins, Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/14695
to review the following change.
Change subject: KUDU-2994: add NO_CHRONY flag
......................................................................
KUDU-2994: add NO_CHRONY flag
This patch addresses KUDU-2994, adding NO_CHRONY cmake/make flag.
If -DNO_CHRONY=1 is specified with cmake options, then the Kudu testing
framework does not rely on chronyc/chronyd, and no corresponding
binaries are deployed under $BUILD_DIR/bin directory. Also, the
libmini_chronyd and libmini_chronyd_test_util libraries are not built
and references to MiniChronyd are removed from ExternalMiniCluster
in that case.
The build_mini_cluster_binaries.sh script was updated to include
-DNO_CHRONY=1 option correspondingly.
I verified that the result set of tests passes using dist-test:
http://dist-test.cloudera.org/job?job_id=aserbin.1573546681.122233
Change-Id: I95495f8a2418546048e2ea28c4f44cb399f08fd3
Reviewed-on: http://gerrit.cloudera.org:8080/14691
Reviewed-by: Adar Dembo <[email protected]>
Tested-by: Kudu Jenkins
(cherry picked from commit 74bf0859c01f20de777e499805ddc256b5e9a6a1)
---
M CMakeLists.txt
M build-support/mini-cluster/build_mini_cluster_binaries.sh
M src/kudu/clock/CMakeLists.txt
M src/kudu/clock/ntp-test.cc
M src/kudu/mini-cluster/CMakeLists.txt
M src/kudu/mini-cluster/external_mini_cluster-test.cc
M src/kudu/mini-cluster/external_mini_cluster.cc
M src/kudu/mini-cluster/external_mini_cluster.h
8 files changed, 107 insertions(+), 35 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/95/14695/1
--
To view, visit http://gerrit.cloudera.org:8080/14695
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.11.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I95495f8a2418546048e2ea28c4f44cb399f08fd3
Gerrit-Change-Number: 14695
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
