Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14713 )
Change subject: [java] fixed bug in the connection negotiation code ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/14713/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14713/3//COMMIT_MSG@7 PS3, Line 7: typo > typo? shouldn't it be a bug or error instead? Done http://gerrit.cloudera.org:8080/#/c/14713/3/java/kudu-client/src/main/java/org/apache/kudu/client/Connection.java File java/kudu-client/src/main/java/org/apache/kudu/client/Connection.java: http://gerrit.cloudera.org:8080/#/c/14713/3/java/kudu-client/src/main/java/org/apache/kudu/client/Connection.java@447 PS3, Line 447: // There's a race in Netty where, when we call Channel.close(), it tries > nit: indentation Done -- To view, visit http://gerrit.cloudera.org:8080/14713 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7bfd428128e224f03901a6cd7b33283495a28d54 Gerrit-Change-Number: 14713 Gerrit-PatchSet: 4 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Fri, 15 Nov 2019 20:51:13 +0000 Gerrit-HasComments: Yes
