Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14154 )
Change subject: KUDU-2914: Rebalance tool support moving replicas from some specific tablet servers ...................................................................... Patch Set 12: (2 comments) http://gerrit.cloudera.org:8080/#/c/14154/12/src/kudu/tools/rebalancer_tool-test.cc File src/kudu/tools/rebalancer_tool-test.cc: http://gerrit.cloudera.org:8080/#/c/14154/12/src/kudu/tools/rebalancer_tool-test.cc@757 PS12, Line 757: IsRebalancingInProgress() > It's quiet difficult to know which tablet server is in progress of copying OK, I just wanted to know whether you saw any flakiness in the test due to those conditions. If no flakiness is observed, then it's all right then. http://gerrit.cloudera.org:8080/#/c/14154/12/src/kudu/tools/rebalancer_tool.cc File src/kudu/tools/rebalancer_tool.cc: http://gerrit.cloudera.org:8080/#/c/14154/12/src/kudu/tools/rebalancer_tool.cc@1243 PS12, Line 1243: has_updates |= s.ok() > I think the 'has_updates' variable indicates whether the statuses of in-pro I think the re-synchronization of the cluster state happens only in case of an error, but otherwise the inner cycle of RebalancerTool::RunWith() ends if no updated were detected, and then next set of moves is required from algorithm. Anyway, I agree this piece looks fishy and it seems there might be some bug here. Could you please separate this change into its own patch? That way it will be easier to reason about this and track related issues, if any. Thanks! -- To view, visit http://gerrit.cloudera.org:8080/14154 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I86cfb740030946c13db1a9ca63d241f4907d6c89 Gerrit-Change-Number: 14154 Gerrit-PatchSet: 12 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hannah Nguyen <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Comment-Date: Tue, 19 Nov 2019 07:20:22 +0000 Gerrit-HasComments: Yes
