Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14742 )
Change subject: rebalancer: fix on Runner::UpdateMovesInProgressStatus() ...................................................................... Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/14742/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14742/1//COMMIT_MSG@14 PS1, Line 14: When no pending operation : completed, the rebalancer tool would try to get a new set of moves : from th > nit: I don't think this is what was happening. I think in that case the re Done http://gerrit.cloudera.org:8080/#/c/14742/1/src/kudu/rebalance/rebalancer.h File src/kudu/rebalance/rebalancer.h: http://gerrit.cloudera.org:8080/#/c/14742/1/src/kudu/rebalance/rebalancer.h@180 PS1, Line 180: the > their Done http://gerrit.cloudera.org:8080/#/c/14742/1/src/kudu/rebalance/rebalancer.h@181 PS1, Line 181: at l > nit: at least one Done http://gerrit.cloudera.org:8080/#/c/14742/1/src/kudu/rebalance/rebalancer.h@181 PS1, Line 181: ss move operati > operation was Done http://gerrit.cloudera.org:8080/#/c/14742/1/src/kudu/tools/rebalancer_tool.cc File src/kudu/tools/rebalancer_tool.cc: http://gerrit.cloudera.org:8080/#/c/14742/1/src/kudu/tools/rebalancer_tool.cc@529 PS1, Line 529: while (!is_timed_out) { > Maybe, move this variable into the scope of the 'while' loop below, closer Done http://gerrit.cloudera.org:8080/#/c/14742/1/src/kudu/tools/rebalancer_tool.cc@566 PS1, Line 566: Also, do the same if not a single pending move has left. : break; > nit: Also, do the same if not a single pending move has left. Done -- To view, visit http://gerrit.cloudera.org:8080/14742 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8a25574d13f36a8f4f98f4340aa2086711b1c741 Gerrit-Change-Number: 14742 Gerrit-PatchSet: 2 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Comment-Date: Wed, 20 Nov 2019 03:36:18 +0000 Gerrit-HasComments: Yes
