Hello Andrew Wong,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/14767
to review the following change.
Change subject: log: refactor close and replace last segment
......................................................................
log: refactor close and replace last segment
Log::Close and SegmentAllocator::RollOver both tried to do the same thing,
except Log::Close didn't actually need to replace the last segment, nor did
it need to close the current segment with state_lock_ held.
I also snuck in a small fix to LogIndex::IndexChunk::Open's use of
ftruncate, and a visibility fix to a SegmentAllocator member.
Change-Id: I871b43514cbafe9a9b594a551fe653d766298123
---
M src/kudu/consensus/log.cc
M src/kudu/consensus/log.h
M src/kudu/consensus/log_index.cc
3 files changed, 56 insertions(+), 39 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/67/14767/1
--
To view, visit http://gerrit.cloudera.org:8080/14767
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I871b43514cbafe9a9b594a551fe653d766298123
Gerrit-Change-Number: 14767
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
