Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14771 )
Change subject: www: Add tablet on_disk_size info to /table ...................................................................... Patch Set 2: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/14771/2/www/table.mustache File www/table.mustache: http://gerrit.cloudera.org:8080/#/c/14771/2/www/table.mustache@99 PS2, Line 99: <table data-toggle="table" class='table table-striped table-hover'> Remind me what this does? http://gerrit.cloudera.org:8080/#/c/14771/2/www/table.mustache@105 PS2, Line 105: <th data-sorter="bytesSorter" data-sortable="true">On-Disk Size (pre-replication)</th> Should we somehow stipulate that this is based on what the LEADER replica reported? Seems useful to know, but hard to describe all that in just the table header. -- To view, visit http://gerrit.cloudera.org:8080/14771 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8cd84420968383d11658df45719a5b2070505291 Gerrit-Change-Number: 14771 Gerrit-PatchSet: 2 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 21 Nov 2019 22:38:19 +0000 Gerrit-HasComments: Yes
