Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14812 )
Change subject: tools: expose fault tolerant scans to scanner tool ...................................................................... Patch Set 1: (1 comment) Maybe a new unit test? http://gerrit.cloudera.org:8080/#/c/14812/1/src/kudu/tools/tool_action_perf.cc File src/kudu/tools/tool_action_perf.cc: http://gerrit.cloudera.org:8080/#/c/14812/1/src/kudu/tools/tool_action_perf.cc@884 PS1, Line 884: .AddOptionalParameter("ordered_scan") Not sure it's worth using both FT and ORDERED terminology. I know this is a fundamentally different approach (i.e. it's a client-less scan), but do you think we should pretend this is also FT? -- To view, visit http://gerrit.cloudera.org:8080/14812 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I19dcee286a30b3d008df30a3af57982ea44298d0 Gerrit-Change-Number: 14812 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 02 Dec 2019 05:15:11 +0000 Gerrit-HasComments: Yes
