Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/14353 )
Change subject: KUDU-1938 Make UTF-8 truncation faster pt 1 ...................................................................... Patch Set 11: (5 comments) http://gerrit.cloudera.org:8080/#/c/14353/9/src/kudu/util/char_util-test.cc File src/kudu/util/char_util-test.cc: http://gerrit.cloudera.org:8080/#/c/14353/9/src/kudu/util/char_util-test.cc@39 PS9, Line 39: > KuduTest has an env_ member. Done http://gerrit.cloudera.org:8080/#/c/14353/9/src/kudu/util/char_util-test.cc@82 PS9, Line 82: ASSERT_EQ(9756, result.size()); > Nit: indentation. And wrapping. Done http://gerrit.cloudera.org:8080/#/c/14353/9/src/kudu/util/char_util-test.cc@87 PS9, Line 87: TEST_F(CharUtilTest, CorrectnessTestIncompleteUtf8) { : Slice result; : Slice test_data = "aaaa > Combine? Done http://gerrit.cloudera.org:8080/#/c/14353/10/src/kudu/util/char_util-test.cc File src/kudu/util/char_util-test.cc: http://gerrit.cloudera.org:8080/#/c/14353/10/src/kudu/util/char_util-test.cc@50 PS10, Line 50: > using Done http://gerrit.cloudera.org:8080/#/c/14353/7/src/kudu/util/char_util.cc File src/kudu/util/char_util.cc: http://gerrit.cloudera.org:8080/#/c/14353/7/src/kudu/util/char_util.cc@32 PS7, Line 32: while (num_bytes < size) { > Oh so 8-byte alignment isn't important? Interesting. yeah I thought it was, but based on the benchmarks it was actually faster without the alignment. -- To view, visit http://gerrit.cloudera.org:8080/14353 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iebb98e18a3619029d9b0bc224c7dead89a3d7374 Gerrit-Change-Number: 14353 Gerrit-PatchSet: 11 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 03 Dec 2019 22:31:17 +0000 Gerrit-HasComments: Yes
