Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14822 )
Change subject: log_index: use RWFiles for IO ...................................................................... Patch Set 1: Code-Review+2 (3 comments) http://gerrit.cloudera.org:8080/#/c/14822/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14822/1//COMMIT_MSG@15 PS1, Line 15: failures during memory mapped IO BTW, what kind of failures did we get there in Kudu? Something like not enough space, etc.? http://gerrit.cloudera.org:8080/#/c/14822/1//COMMIT_MSG@20 PS1, Line 20: IO through RWFile Do we expect less or more memory allocated in this case compared with the case when the IO was done via mmap-ed files? http://gerrit.cloudera.org:8080/#/c/14822/1/src/kudu/consensus/log_index.cc File src/kudu/consensus/log_index.cc: http://gerrit.cloudera.org:8080/#/c/14822/1/src/kudu/consensus/log_index.cc@237 PS1, Line 237: "Unable to delete index chunk " << path; Maybe, add information from the Status object (i.e. s.ToString()) into the message? -- To view, visit http://gerrit.cloudera.org:8080/14822 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I75c0476bbd9be55657291c85488b9121e04a91de Gerrit-Change-Number: 14822 Gerrit-PatchSet: 1 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 04 Dec 2019 07:32:59 +0000 Gerrit-HasComments: Yes
