Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14833 )
Change subject: clang_tidy_gerrit: disable readability-magic-numbers check ...................................................................... clang_tidy_gerrit: disable readability-magic-numbers check Although useful, we lean quite heavily on magic numbers in tests, and as there's no way to disable this check in specific files, let's disable it across the board. Change-Id: I26c39915f4fc96078116552286248fb3eb3704cf Reviewed-on: http://gerrit.cloudera.org:8080/14833 Tested-by: Adar Dembo <[email protected]> Reviewed-by: Andrew Wong <[email protected]> --- M build-support/clang_tidy_gerrit.py 1 file changed, 8 insertions(+), 0 deletions(-) Approvals: Adar Dembo: Verified Andrew Wong: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/14833 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I26c39915f4fc96078116552286248fb3eb3704cf Gerrit-Change-Number: 14833 Gerrit-PatchSet: 2 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]>
