Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/14853 )
Change subject: Update IWYU fix_includes.py ...................................................................... Patch Set 2: > Patch Set 2: Code-Review+2 > > Do the new IWYU goodies affect our usage of fix_includes.py? Are there any > tangible changes to its recommendations? I don't think there are, there are some new flags like --reorder/--noreorder, --basedir and --only_re to match files to check with a regular expression, but I didn't change anything regarding how to invoke it. Only reason I pushed this is because I already rebased it when we thought there was a compatibility issue with the ordering. We also might want to use these new features in the future and it should make it easier to rebase on top of newer versions if they come out. -- To view, visit http://gerrit.cloudera.org:8080/14853 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I967382f79fc0172b79b5d42347e9d9c61ed1ea1e Gerrit-Change-Number: 14853 Gerrit-PatchSet: 2 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Thu, 05 Dec 2019 20:42:41 +0000 Gerrit-HasComments: No
