Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14871 )
Change subject: fs: separate out directory management code ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/14871/2/src/kudu/fs/data_dirs.h File src/kudu/fs/data_dirs.h: http://gerrit.cloudera.org:8080/#/c/14871/2/src/kudu/fs/data_dirs.h@201 PS2, Line 201: std::unique_ptr<DirInstanceMetadataFile>, > warning: all parameters should be named in a function [readability-named-pa Done http://gerrit.cloudera.org:8080/#/c/14871/2/src/kudu/fs/data_dirs.h@206 PS2, Line 206: virtual Status PopulateDirectoryMaps(const std::vector<std::unique_ptr<Dir>>& dds) override; > warning: function 'kudu::fs::DataDirManager::PopulateDirectoryMaps' has a d Done -- To view, visit http://gerrit.cloudera.org:8080/14871 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I633e1e32845b08eb24c5327a04af344b579b186a Gerrit-Change-Number: 14871 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 10 Dec 2019 08:25:07 +0000 Gerrit-HasComments: Yes
