liusheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/14873 )
Change subject: [KUDU-3007] Add patch for crcutil to support aarch64 platform ...................................................................... Patch Set 1: (4 comments) Hi Adar Dembo, thank you for your review. http://gerrit.cloudera.org:8080/#/c/14873/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14873/1//COMMIT_MSG@10 PS1, Line 10: depdency > dependency thank you, done http://gerrit.cloudera.org:8080/#/c/14873/1/thirdparty/download-thirdparty.sh File thirdparty/download-thirdparty.sh: http://gerrit.cloudera.org:8080/#/c/14873/1/thirdparty/download-thirdparty.sh@300 PS1, Line 300: CRCUTIL_PATCHLEVEL=1 > Need to change this to 2. thank you, done http://gerrit.cloudera.org:8080/#/c/14873/1/thirdparty/patches/crcutil-support-on-aarch64.patch File thirdparty/patches/crcutil-support-on-aarch64.patch: http://gerrit.cloudera.org:8080/#/c/14873/1/thirdparty/patches/crcutil-support-on-aarch64.patch@7 PS1, Line 7: +if [[ "$(uname -p)" == "aarch64" ]]; then : + crcutil_flags="-DCRCUTIL_USE_MM_CRC32=1 -Wall -march=armv8-a -Icode -Iexamples -Itests -O3" : +fi : + > Could you incorporate this into the if/else above so that you needn't redef not only -march=armv8-a needed, the flags of '-msse2', '-mcrc32' and '-msse4.2' are not supportted on aarch64 server. http://gerrit.cloudera.org:8080/#/c/14873/1/thirdparty/patches/crcutil-support-on-aarch64.patch@92 PS1, Line 92: +#if CRCUTIL_USE_MM_CRC32 && (HAVE_I386 || HAVE_AMD64 || HAVE_AARCH64) > There's a corresponding #endif whose comment needs to be updated. oh, yes, thank you :) -- To view, visit http://gerrit.cloudera.org:8080/14873 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3a95504b52407d3e213ff76bf9ebcd960ae4fde3 Gerrit-Change-Number: 14873 Gerrit-PatchSet: 1 Gerrit-Owner: liusheng <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: liusheng <[email protected]> Gerrit-Comment-Date: Tue, 10 Dec 2019 10:26:43 +0000 Gerrit-HasComments: Yes
