Alexey Serbin has submitted this change and it was merged. (
http://gerrit.cloudera.org:8080/14899 )
Change subject: [util] a small clean-up on MAYBE_RETURN_FAILURE
......................................................................
[util] a small clean-up on MAYBE_RETURN_FAILURE
Updated MAYBE_RETURN_FAILURE macro to follow the 'do {...} while (0)'
pattern so static code analyzers doesn't output warnings on an
empty statements when encountering constructs like
MAYBE_RETURN_FAILURE(...);
This patch doesn't contain any functional modifications.
Change-Id: Ieb9e172b4f2e1cfa712be08b9527f50bd0fe09e5
Reviewed-on: http://gerrit.cloudera.org:8080/14899
Tested-by: Alexey Serbin <[email protected]>
Reviewed-by: Adar Dembo <[email protected]>
Reviewed-by: Andrew Wong <[email protected]>
---
M src/kudu/util/env_posix.cc
M src/kudu/util/fault_injection.h
2 files changed, 8 insertions(+), 9 deletions(-)
Approvals:
Alexey Serbin: Verified
Adar Dembo: Looks good to me, approved
Andrew Wong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/14899
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ieb9e172b4f2e1cfa712be08b9527f50bd0fe09e5
Gerrit-Change-Number: 14899
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
