Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14910 )
Change subject: KUDU-3002: prioritize WAL unanchoring when under memory pressure ...................................................................... Patch Set 2: (1 comment) TSAN failure looks test-only but legit. http://gerrit.cloudera.org:8080/#/c/14910/2/src/kudu/util/maintenance_manager.cc File src/kudu/util/maintenance_manager.cc: http://gerrit.cloudera.org:8080/#/c/14910/2/src/kudu/util/maintenance_manager.cc@429 PS2, Line 429: ignore the target replay size and flush whichever op : // anchors the most WALs (the op should also free memory). Could you elaborate on why this is better than flushing whatever anchors the most memory? -- To view, visit http://gerrit.cloudera.org:8080/14910 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibd85e8f2904a36b74cd6a3038c9ec49bb1ff9844 Gerrit-Change-Number: 14910 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Mon, 16 Dec 2019 21:28:03 +0000 Gerrit-HasComments: Yes
