Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/14329 )
Change subject: [java] KUDU-2791: process communicates via protobuf-based protocol ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/14329/6/java/kudu-subprocess/build.gradle File java/kudu-subprocess/build.gradle: http://gerrit.cloudera.org:8080/#/c/14329/6/java/kudu-subprocess/build.gradle@25 PS6, Line 25: compile libs.hadoopCommon Is this included just for Configuration.Java? There should be something more lightweight that can be used. http://gerrit.cloudera.org:8080/#/c/14329/6/java/kudu-subprocess/build.gradle@56 PS6, Line 56: configurations.compile.collect { it.isDirectory() ? it : zipTree(it) } The shadow plugin, included above, should handle the shading of this jar for you. Is this required? -- To view, visit http://gerrit.cloudera.org:8080/14329 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaf9ad24dbc9acc681284b6433836271b5b4c7982 Gerrit-Change-Number: 14329 Gerrit-PatchSet: 6 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 16 Dec 2019 22:08:15 +0000 Gerrit-HasComments: Yes
