Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/14922 )
Change subject: [metrics] Add a flag to set a default metric level ...................................................................... Patch Set 1: (7 comments) http://gerrit.cloudera.org:8080/#/c/14922/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14922/1//COMMIT_MSG@7 PS1, Line 7: [metrics] Add a flag to set a default metric level > +1 Done http://gerrit.cloudera.org:8080/#/c/14922/1//COMMIT_MSG@7 PS1, Line 7: [metrics] Add a flag to set a default metric level > May want to rationalize why you're re-adding this, as I made a rather force Done http://gerrit.cloudera.org:8080/#/c/14922/1//COMMIT_MSG@10 PS1, Line 10: serverity > severity Done http://gerrit.cloudera.org:8080/#/c/14922/1/src/kudu/server/default_path_handlers.cc File src/kudu/server/default_path_handlers.cc: http://gerrit.cloudera.org:8080/#/c/14922/1/src/kudu/server/default_path_handlers.cc@80 PS1, Line 80: metrics_default_level > Mind adding a validator for the value of this flag? Done http://gerrit.cloudera.org:8080/#/c/14922/1/src/kudu/server/default_path_handlers.cc@81 PS1, Line 81: "The default severity level to use when filtering the metrics " > nit: add a stop Done http://gerrit.cloudera.org:8080/#/c/14922/1/src/kudu/server/default_path_handlers.cc@82 PS1, Line 82: "Valid choices are 'debug', 'info', and 'warn'. " > Do you think it's worth explaining how the ordering of these work? I.e. deb Done http://gerrit.cloudera.org:8080/#/c/14922/1/src/kudu/server/default_path_handlers.cc@83 PS1, Line 83: level > nit: 'level' query parameter? Done -- To view, visit http://gerrit.cloudera.org:8080/14922 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I296fda7a6fefb952f1522bba3c1ff9804d5ce5cc Gerrit-Change-Number: 14922 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 19 Dec 2019 17:46:53 +0000 Gerrit-HasComments: Yes
