Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14932 )
Change subject: [monotime] deprecating MonoTime::GetDeltaSince() ...................................................................... Patch Set 1: Verified+1 IWYU went mad, and I'm going to ignore its crappy suggestions. If I follow the recommendation from this build at http://jenkins.kudu.apache.org/job/kudu-gerrit/19927/BUILD_TYPE=IWYU/artifact/build/latest/test-logs/iwyu.log >>> Fixing #includes in >>> '/home/jenkins-slave/workspace/kudu-master/2/src/kudu/tserver/tablet_service.cc' @@ -27,6 +27,7 @@ #include <string> #include <type_traits> #include <unordered_set> +#include <utility> #include <vector> #include <boost/optional/optional.hpp> @@ -90,6 +91,7 @@ #include "kudu/tserver/tserver_admin.pb.h" #include "kudu/tserver/tserver_service.pb.h" #include "kudu/util/auto_release_pool.h" +#include "kudu/util/bitset.h" #include "kudu/util/crc.h" #include "kudu/util/debug/trace_event.h" #include "kudu/util/faststring.h" IWYU would have edited 1 files on your behalf. Then at my CentOS6.6 build machine it suggests I need to remove it: >>> Fixing #includes in >>> '/data/8/aserbin/Projects/kudu/src/kudu/tserver/tablet_service.cc' @@ -27,7 +27,6 @@ #include <string> #include <type_traits> #include <unordered_set> -#include <utility> #include <vector> #include <boost/optional/optional.hpp> @@ -91,7 +90,6 @@ #include "kudu/tserver/tserver_admin.pb.h" #include "kudu/tserver/tserver_service.pb.h" #include "kudu/util/auto_release_pool.h" -#include "kudu/util/bitset.h" #include "kudu/util/crc.h" #include "kudu/util/debug/trace_event.h" #include "kudu/util/faststring.h" IWYU would have edited 1 files on your behalf. I'm going to ignore this crap. -- To view, visit http://gerrit.cloudera.org:8080/14932 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9611c8a20e02b117757842bc3b46b8faf82d9700 Gerrit-Change-Number: 14932 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Thu, 19 Dec 2019 23:08:40 +0000 Gerrit-HasComments: No
