Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14937 )
Change subject: metrics: expose 'total_sum' and 'total_count' values for MeanGauge metrics ...................................................................... Patch Set 1: (1 comment) Could you add a test to exercise the new functionality? http://gerrit.cloudera.org:8080/#/c/14937/1/src/kudu/util/metrics.cc File src/kudu/util/metrics.cc: http://gerrit.cloudera.org:8080/#/c/14937/1/src/kudu/util/metrics.cc@844 PS1, Line 844: void MeanGauge::WriteValue(JsonWriter* writer) const { If you wrote total_sum/total_count _after_ value, couldn't you continue to have the superclass write the "value" string? That seems better in that it reduces the likelihood that someone adds a new gauge and forgets to write "value" in WriteValue(). -- To view, visit http://gerrit.cloudera.org:8080/14937 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id28f693140da79d466af57fd26064a3653ea2995 Gerrit-Change-Number: 14937 Gerrit-PatchSet: 1 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 20 Dec 2019 19:03:01 +0000 Gerrit-HasComments: Yes
