Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14942 )
Change subject: protoc-gen-krpc: remove kudu_util dependency and clean up ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/14942/2/src/kudu/rpc/protoc-gen-krpc.cc File src/kudu/rpc/protoc-gen-krpc.cc: http://gerrit.cloudera.org:8080/#/c/14942/2/src/kudu/rpc/protoc-gen-krpc.cc@96 PS2, Line 96: const string& path = file->name(); > nit: maybe move this down after the condition? Done -- To view, visit http://gerrit.cloudera.org:8080/14942 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifcde701648ca87c64dd3a09468df97654d58317a Gerrit-Change-Number: 14942 Gerrit-PatchSet: 4 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Volodymyr Verovkin <[email protected]> Gerrit-Comment-Date: Sat, 21 Dec 2019 00:40:01 +0000 Gerrit-HasComments: Yes
