Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14946 )
Change subject: [consensus] KUDU-2839 fix assert in GetParticipantRole() ...................................................................... [consensus] KUDU-2839 fix assert in GetParticipantRole() Before this patch, the consistency check in GetParticipantRole() was incorrect. It tried to search for the replica UUID against pending config, but replica UUID comes from committed config at the only call site of the function in CatalogManager::BuildLocationsForTablet(). The pending Raft config might have replica already removed in case if there is move/replace replica operation in progress. The incorrect assertion triggered here: http://dist-test.cloudera.org/job?job_id=aserbin.1577145505.5646 I also did a minor clean up of the code around. This is a follow-up to 586e957f76a547340f2ab93a7eebc3f116ff825e. Change-Id: I1a490f5b61dda8cebb8ee9bd9171ef3aa733a148 Reviewed-on: http://gerrit.cloudera.org:8080/14946 Tested-by: Kudu Jenkins Reviewed-by: Bankim Bhavsar <[email protected]> Reviewed-by: Adar Dembo <[email protected]> --- M src/kudu/consensus/quorum_util.cc M src/kudu/consensus/quorum_util.h M src/kudu/master/catalog_manager.cc M src/kudu/master/catalog_manager.h 4 files changed, 12 insertions(+), 14 deletions(-) Approvals: Kudu Jenkins: Verified Bankim Bhavsar: Looks good to me, but someone else must approve Adar Dembo: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/14946 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I1a490f5b61dda8cebb8ee9bd9171ef3aa733a148 Gerrit-Change-Number: 14946 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120)
