Adar Dembo has submitted this change and it was merged. (
http://gerrit.cloudera.org:8080/14956 )
Change subject: [util] fix compilation warnings in RELEASE mode
......................................................................
[util] fix compilation warnings in RELEASE mode
Prior to this fix, compiling in RELEASE mode with 3rd-party clang would
output warning messages like below:
src/kudu/util/block_bloom_filter.cc:171:18: \
warning: expression result unused [-Wunused-value]
DCHECK_NOTNULL(directory_);
This patch addresses that, placing the DCHECK_NOTNULL() macro
into expressions which use directory_ member field.
Change-Id: Ia059413ad2962a22a32ab92773a2d6871809830a
Reviewed-on: http://gerrit.cloudera.org:8080/14956
Tested-by: Kudu Jenkins
Reviewed-by: Bankim Bhavsar <[email protected]>
Reviewed-by: Adar Dembo <[email protected]>
---
M src/kudu/util/block_bloom_filter.cc
1 file changed, 4 insertions(+), 6 deletions(-)
Approvals:
Kudu Jenkins: Verified
Bankim Bhavsar: Looks good to me, but someone else must approve
Adar Dembo: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/14956
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia059413ad2962a22a32ab92773a2d6871809830a
Gerrit-Change-Number: 14956
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Bankim Bhavsar <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)